MIPS: KVM: Fix kvm_debug bit-rottage
Fix build errors when DEBUG is defined in arch/mips/kvm/. - The DEBUG code in kvm_mips_handle_tlbmod() was missing some variables. - The DEBUG code in kvm_mips_host_tlb_write() was conditional on an undefined "debug" variable. - The DEBUG code in kvm_mips_host_tlb_inv() accessed asid_map directly rather than using kvm_mips_get_user_asid(). Also fixed brace placement. Signed-off-by: James Hogan <james.hogan@imgtec.com> Cc: Paolo Bonzini <pbonzini@redhat.com> Cc: Gleb Natapov <gleb@kernel.org> Cc: kvm@vger.kernel.org Cc: Ralf Baechle <ralf@linux-mips.org> Cc: linux-mips@linux-mips.org Cc: Sanjay Lal <sanjayl@kymasys.com> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
This commit is contained in:
Родитель
2dca3725cb
Коммит
3d65483371
|
@ -1831,8 +1831,12 @@ kvm_mips_handle_tlbmod(unsigned long cause, uint32_t *opc,
|
||||||
struct kvm_run *run, struct kvm_vcpu *vcpu)
|
struct kvm_run *run, struct kvm_vcpu *vcpu)
|
||||||
{
|
{
|
||||||
enum emulation_result er = EMULATE_DONE;
|
enum emulation_result er = EMULATE_DONE;
|
||||||
|
|
||||||
#ifdef DEBUG
|
#ifdef DEBUG
|
||||||
|
struct mips_coproc *cop0 = vcpu->arch.cop0;
|
||||||
|
unsigned long entryhi = (vcpu->arch.host_cp0_badvaddr & VPN2_MASK) |
|
||||||
|
(kvm_read_c0_guest_entryhi(cop0) & ASID_MASK);
|
||||||
|
int index;
|
||||||
|
|
||||||
/*
|
/*
|
||||||
* If address not in the guest TLB, then we are in trouble
|
* If address not in the guest TLB, then we are in trouble
|
||||||
*/
|
*/
|
||||||
|
|
|
@ -233,12 +233,9 @@ kvm_mips_host_tlb_write(struct kvm_vcpu *vcpu, unsigned long entryhi,
|
||||||
tlbw_use_hazard();
|
tlbw_use_hazard();
|
||||||
|
|
||||||
#ifdef DEBUG
|
#ifdef DEBUG
|
||||||
if (debug) {
|
kvm_debug("@ %#lx idx: %2d [entryhi(R): %#lx] entrylo0(R): 0x%08lx, entrylo1(R): 0x%08lx\n",
|
||||||
kvm_debug("@ %#lx idx: %2d [entryhi(R): %#lx] "
|
vcpu->arch.pc, idx, read_c0_entryhi(),
|
||||||
"entrylo0(R): 0x%08lx, entrylo1(R): 0x%08lx\n",
|
read_c0_entrylo0(), read_c0_entrylo1());
|
||||||
vcpu->arch.pc, idx, read_c0_entryhi(),
|
|
||||||
read_c0_entrylo0(), read_c0_entrylo1());
|
|
||||||
}
|
|
||||||
#endif
|
#endif
|
||||||
|
|
||||||
/* Flush D-cache */
|
/* Flush D-cache */
|
||||||
|
@ -507,10 +504,9 @@ int kvm_mips_host_tlb_inv(struct kvm_vcpu *vcpu, unsigned long va)
|
||||||
local_irq_restore(flags);
|
local_irq_restore(flags);
|
||||||
|
|
||||||
#ifdef DEBUG
|
#ifdef DEBUG
|
||||||
if (idx > 0) {
|
if (idx > 0)
|
||||||
kvm_debug("%s: Invalidated entryhi %#lx @ idx %d\n", __func__,
|
kvm_debug("%s: Invalidated entryhi %#lx @ idx %d\n", __func__,
|
||||||
(va & VPN2_MASK) | (vcpu->arch.asid_map[va & ASID_MASK] & ASID_MASK), idx);
|
(va & VPN2_MASK) | kvm_mips_get_user_asid(vcpu), idx);
|
||||||
}
|
|
||||||
#endif
|
#endif
|
||||||
|
|
||||||
return 0;
|
return 0;
|
||||||
|
|
Загрузка…
Ссылка в новой задаче