device: Make dev_WARN/dev_WARN_ONCE print device as well as driver name

dev_WARN() and dev_WARN_ONCE() are annoying because (1) they include
only the driver name, not the device name, and (2) they print a spurious
newline in the middle.  This results in messages like this that are less
useful than they should be:

  [   40.094995] Device pcieport
  disabling already-disabled device

This patch makes them work more like dev_printk().

Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Reviewed-by: Felipe Balbi <balbi@ti.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Bjorn Helgaas 2013-10-24 15:42:33 -06:00 коммит произвёл Greg Kroah-Hartman
Родитель d1c1459e45
Коммит 3eae136717
1 изменённых файлов: 5 добавлений и 6 удалений

Просмотреть файл

@ -1170,16 +1170,15 @@ do { \
#endif #endif
/* /*
* dev_WARN*() acts like dev_printk(), but with the key difference * dev_WARN*() acts like dev_printk(), but with the key difference of
* of using a WARN/WARN_ON to get the message out, including the * using WARN/WARN_ONCE to include file/line information and a backtrace.
* file/line information and a backtrace.
*/ */
#define dev_WARN(dev, format, arg...) \ #define dev_WARN(dev, format, arg...) \
WARN(1, "Device: %s\n" format, dev_driver_string(dev), ## arg); WARN(1, "%s %s: " format, dev_driver_string(dev), dev_name(dev), ## arg);
#define dev_WARN_ONCE(dev, condition, format, arg...) \ #define dev_WARN_ONCE(dev, condition, format, arg...) \
WARN_ONCE(condition, "Device %s\n" format, \ WARN_ONCE(condition, "%s %s: " format, \
dev_driver_string(dev), ## arg) dev_driver_string(dev), dev_name(dev), ## arg)
/* Create alias, so I can be autoloaded. */ /* Create alias, so I can be autoloaded. */
#define MODULE_ALIAS_CHARDEV(major,minor) \ #define MODULE_ALIAS_CHARDEV(major,minor) \