media: tm6000: use irqsave() in USB's complete callback
The USB completion callback does not disable interrupts while acquiring the lock. We want to remove the local_irq_disable() invocation from __usb_hcd_giveback_urb() and therefore it is required for the callback handler to disable the interrupts while acquiring the lock. The callback may be invoked either in IRQ or BH context depending on the USB host controller. Use the _irqsave() variant of the locking primitives. Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> Acked-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Родитель
273925c777
Коммит
3f3ff6e0d8
|
@ -419,6 +419,7 @@ static void tm6000_irq_callback(struct urb *urb)
|
|||
{
|
||||
struct tm6000_dmaqueue *dma_q = urb->context;
|
||||
struct tm6000_core *dev = container_of(dma_q, struct tm6000_core, vidq);
|
||||
unsigned long flags;
|
||||
int i;
|
||||
|
||||
switch (urb->status) {
|
||||
|
@ -436,9 +437,9 @@ static void tm6000_irq_callback(struct urb *urb)
|
|||
break;
|
||||
}
|
||||
|
||||
spin_lock(&dev->slock);
|
||||
spin_lock_irqsave(&dev->slock, flags);
|
||||
tm6000_isoc_copy(urb);
|
||||
spin_unlock(&dev->slock);
|
||||
spin_unlock_irqrestore(&dev->slock, flags);
|
||||
|
||||
/* Reset urb buffers */
|
||||
for (i = 0; i < urb->number_of_packets; i++) {
|
||||
|
|
Загрузка…
Ссылка в новой задаче