ALSA: hda - Fix silent speaker output due to mute LED fixup
The recent fixups for HP laptops to support the mute LED made the speaker output silent on some machines. It turned out that they use the NID 0x18 for the speaker while it's also used for controlling the LED via VREF bits although the current driver code blindly assumes that such a node is a mic pin (where 0x18 is usually so). This patch fixes the problem by only changing the VREF bits and keeping the other pin ctl bits. Reported-and-tested-by: Hui Wang <hui.wang@canonical.com> Cc: <stable@vger.kernel.org> Signed-off-by: Takashi Iwai <tiwai@suse.de>
This commit is contained in:
Родитель
8314f22589
Коммит
415d555e6b
|
@ -3371,8 +3371,9 @@ static void alc269_fixup_mic_mute_hook(void *private_data, int enabled)
|
|||
|
||||
if (spec->mute_led_polarity)
|
||||
enabled = !enabled;
|
||||
pinval = AC_PINCTL_IN_EN |
|
||||
(enabled ? AC_PINCTL_VREF_HIZ : AC_PINCTL_VREF_80);
|
||||
pinval = snd_hda_codec_get_pin_target(codec, spec->mute_led_nid);
|
||||
pinval &= ~AC_PINCTL_VREFEN;
|
||||
pinval |= enabled ? AC_PINCTL_VREF_HIZ : AC_PINCTL_VREF_80;
|
||||
if (spec->mute_led_nid)
|
||||
snd_hda_set_pin_ctl_cache(codec, spec->mute_led_nid, pinval);
|
||||
}
|
||||
|
|
Загрузка…
Ссылка в новой задаче