[PATCH] net/sunrpc/svcsock.c: fix a check
The return value of kernel_recvmsg() should be assigned to "err", not compared with the random value of a never initialized "err" (and the "< 0" check wrongly always returned false since == comparisons never have a result < 0). Spotted by the Coverity checker. Signed-off-by: Adrian Bunk <bunk@stusta.de> Acked-by: Neil Brown <neilb@suse.de> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Родитель
5792a2856a
Коммит
418106d624
|
@ -779,8 +779,8 @@ svc_udp_recvfrom(struct svc_rqst *rqstp)
|
|||
}
|
||||
|
||||
clear_bit(SK_DATA, &svsk->sk_flags);
|
||||
while ((err == kernel_recvmsg(svsk->sk_sock, &msg, NULL,
|
||||
0, 0, MSG_PEEK | MSG_DONTWAIT)) < 0 ||
|
||||
while ((err = kernel_recvmsg(svsk->sk_sock, &msg, NULL,
|
||||
0, 0, MSG_PEEK | MSG_DONTWAIT)) < 0 ||
|
||||
(skb = skb_recv_datagram(svsk->sk_sk, 0, 1, &err)) == NULL) {
|
||||
if (err == -EAGAIN) {
|
||||
svc_sock_received(svsk);
|
||||
|
|
Загрузка…
Ссылка в новой задаче