ASoC: fsl: Fix refcount leak in imx_sgtl5000_probe
of_find_i2c_device_by_node() takes a reference,
In error paths, we should call put_device() to drop
the reference to aviod refount leak.
Fixes: 81e8e49261
("ASoC: fsl: add sgtl5000 clock support for imx-sgtl5000")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Reviewed-by: Fabio Estevam <festevam@gmail.com>
Link: https://lore.kernel.org/r/20220511065803.3957-1-linmq006@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
This commit is contained in:
Родитель
71013db522
Коммит
41cd312dfe
|
@ -120,19 +120,19 @@ static int imx_sgtl5000_probe(struct platform_device *pdev)
|
|||
data = devm_kzalloc(&pdev->dev, sizeof(*data), GFP_KERNEL);
|
||||
if (!data) {
|
||||
ret = -ENOMEM;
|
||||
goto fail;
|
||||
goto put_device;
|
||||
}
|
||||
|
||||
comp = devm_kzalloc(&pdev->dev, 3 * sizeof(*comp), GFP_KERNEL);
|
||||
if (!comp) {
|
||||
ret = -ENOMEM;
|
||||
goto fail;
|
||||
goto put_device;
|
||||
}
|
||||
|
||||
data->codec_clk = clk_get(&codec_dev->dev, NULL);
|
||||
if (IS_ERR(data->codec_clk)) {
|
||||
ret = PTR_ERR(data->codec_clk);
|
||||
goto fail;
|
||||
goto put_device;
|
||||
}
|
||||
|
||||
data->clk_frequency = clk_get_rate(data->codec_clk);
|
||||
|
@ -158,10 +158,10 @@ static int imx_sgtl5000_probe(struct platform_device *pdev)
|
|||
data->card.dev = &pdev->dev;
|
||||
ret = snd_soc_of_parse_card_name(&data->card, "model");
|
||||
if (ret)
|
||||
goto fail;
|
||||
goto put_device;
|
||||
ret = snd_soc_of_parse_audio_routing(&data->card, "audio-routing");
|
||||
if (ret)
|
||||
goto fail;
|
||||
goto put_device;
|
||||
data->card.num_links = 1;
|
||||
data->card.owner = THIS_MODULE;
|
||||
data->card.dai_link = &data->dai;
|
||||
|
@ -174,7 +174,7 @@ static int imx_sgtl5000_probe(struct platform_device *pdev)
|
|||
ret = devm_snd_soc_register_card(&pdev->dev, &data->card);
|
||||
if (ret) {
|
||||
dev_err_probe(&pdev->dev, ret, "snd_soc_register_card failed\n");
|
||||
goto fail;
|
||||
goto put_device;
|
||||
}
|
||||
|
||||
of_node_put(ssi_np);
|
||||
|
@ -182,6 +182,8 @@ static int imx_sgtl5000_probe(struct platform_device *pdev)
|
|||
|
||||
return 0;
|
||||
|
||||
put_device:
|
||||
put_device(&codec_dev->dev);
|
||||
fail:
|
||||
if (data && !IS_ERR(data->codec_clk))
|
||||
clk_put(data->codec_clk);
|
||||
|
|
Загрузка…
Ссылка в новой задаче