greybus: manifest: release cport descriptors to avoid 'excess descriptors' warning

If we fail to initialize a cport of a bundle, we abort the entire
bundle. But that leads to following (unnecessary) warnings as few of the
cport descriptors, belonging to the aborted bundle were never parsed:

"greybus: excess descriptors in interface manifest"

Fix that by releasing all cport descriptors for the aborted bundle.

Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Reviewed-by: Johan Hovold <johan@hovoldconsulting.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>
This commit is contained in:
Viresh Kumar 2015-09-07 16:01:20 +05:30 коммит произвёл Greg Kroah-Hartman
Родитель 98d7fbcad9
Коммит 4317f874f4
1 изменённых файлов: 13 добавлений и 0 удалений

Просмотреть файл

@ -258,6 +258,19 @@ print_error_exit:
GREYBUS_PROTOCOL_CONTROL);
exit:
/*
* Free all cports for this bundle to avoid 'excess descriptors'
* warnings.
*/
list_for_each_entry_safe(desc, next, &intf->manifest_descs, links) {
struct greybus_descriptor_cport *desc_cport = desc->data;
if (desc->type != GREYBUS_TYPE_CPORT)
continue;
if (desc_cport->bundle == bundle_id)
release_manifest_descriptor(desc);
}
return 0; /* Error; count should also be 0 */
}