xfs: Fix error return for fallocate() on XFS
Noticed that through glibc fallocate would return 28 rather than -1 and errno = 28 for ENOSPC. The xfs routines uses XFS_ERROR format positive return error codes while the syscalls use negative return codes. Fixup the two cases in xfs_vn_fallocate syscall to convert to negative. Signed-off-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com> Reviewed-by: Eric Sandeen <sandeen@sandeen.net> Signed-off-by: Alex Elder <aelder@sgi.com>
This commit is contained in:
Родитель
30ac0683dd
Коммит
44a743f687
|
@ -573,7 +573,7 @@ xfs_vn_fallocate(
|
||||||
bf.l_len = len;
|
bf.l_len = len;
|
||||||
|
|
||||||
xfs_ilock(ip, XFS_IOLOCK_EXCL);
|
xfs_ilock(ip, XFS_IOLOCK_EXCL);
|
||||||
error = xfs_change_file_space(ip, XFS_IOC_RESVSP, &bf,
|
error = -xfs_change_file_space(ip, XFS_IOC_RESVSP, &bf,
|
||||||
0, XFS_ATTR_NOLOCK);
|
0, XFS_ATTR_NOLOCK);
|
||||||
if (!error && !(mode & FALLOC_FL_KEEP_SIZE) &&
|
if (!error && !(mode & FALLOC_FL_KEEP_SIZE) &&
|
||||||
offset + len > i_size_read(inode))
|
offset + len > i_size_read(inode))
|
||||||
|
@ -585,7 +585,7 @@ xfs_vn_fallocate(
|
||||||
|
|
||||||
iattr.ia_valid = ATTR_SIZE;
|
iattr.ia_valid = ATTR_SIZE;
|
||||||
iattr.ia_size = new_size;
|
iattr.ia_size = new_size;
|
||||||
error = xfs_setattr(ip, &iattr, XFS_ATTR_NOLOCK);
|
error = -xfs_setattr(ip, &iattr, XFS_ATTR_NOLOCK);
|
||||||
}
|
}
|
||||||
|
|
||||||
xfs_iunlock(ip, XFS_IOLOCK_EXCL);
|
xfs_iunlock(ip, XFS_IOLOCK_EXCL);
|
||||||
|
|
Загрузка…
Ссылка в новой задаче