hwmon: (nct6775) Check array index when accessing temp_offset

smatch complains about a potential out-of-bounds access to the
temp_offset array. That doesn't happen in practice, but it doesn't
hurt to add an explicit check either. This prevents potential problems
in the future (for example if the number of 'fixed' temperature
sensors is increased to add support for another chip).

Signed-off-by: Guenter Roeck <linux@roeck-us.net>
This commit is contained in:
Guenter Roeck 2013-09-11 10:35:47 -07:00
Родитель e8ab508c27
Коммит 45a5b3a183
1 изменённых файлов: 2 добавлений и 1 удалений

Просмотреть файл

@ -1457,7 +1457,8 @@ static struct nct6775_data *nct6775_update_device(struct device *dev)
= nct6775_read_temp(data,
data->reg_temp[j][i]);
}
if (!(data->have_temp_fixed & (1 << i)))
if (i >= NUM_TEMP_FIXED ||
!(data->have_temp_fixed & (1 << i)))
continue;
data->temp_offset[i]
= nct6775_read_value(data, data->REG_TEMP_OFFSET[i]);