nfs: Fix memory leak of export_path
The try_location function is called within a loop by nfs_follow_referral. try_location calls nfs4_pathname_string to created the export_path. nfs4_pathname_string allocates the memory. export_path is stored in the nfs_fs_context/fs_context structure similarly as hostname and source. But whereas the ctx hostname and source are freed before assignment, export_path is not. So if there are multiple loops, the new export_path will overwrite the old without the old being freed. So call kfree for export_path. Signed-off-by: Tom Rix <trix@redhat.com> Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>
This commit is contained in:
Родитель
b7ade38165
Коммит
4659ed7cc8
|
@ -308,6 +308,7 @@ static int try_location(struct fs_context *fc,
|
||||||
if (IS_ERR(export_path))
|
if (IS_ERR(export_path))
|
||||||
return PTR_ERR(export_path);
|
return PTR_ERR(export_path);
|
||||||
|
|
||||||
|
kfree(ctx->nfs_server.export_path);
|
||||||
ctx->nfs_server.export_path = export_path;
|
ctx->nfs_server.export_path = export_path;
|
||||||
|
|
||||||
source = kmalloc(len + 1 + ctx->nfs_server.export_path_len + 1,
|
source = kmalloc(len + 1 + ctx->nfs_server.export_path_len + 1,
|
||||||
|
|
Загрузка…
Ссылка в новой задаче