ipoctal: request_irq after configuration
The request for an IRQ handler must be done after whole configuration. This was not the case for this driver which request the IRQ in the middle of the configuration. Sometimes, it happens that something is not completely configured, we recieve an interrupt thus we stumble into troubles in the IRQ handler. Signed-off-by: Federico Vaga <federico.vaga@cern.ch> Acked-by: Samuel Iglesias Gonsalvez <siglesias@igalia.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Родитель
968d04e8de
Коммит
4847cc073a
|
@ -323,13 +323,6 @@ static int ipoctal_inst_slot(struct ipoctal *ipoctal, unsigned int bus_nr,
|
|||
&block_regs[i].w.imr);
|
||||
}
|
||||
|
||||
/*
|
||||
* IP-OCTAL has different addresses to copy its IRQ vector.
|
||||
* Depending of the carrier these addresses are accesible or not.
|
||||
* More info in the datasheet.
|
||||
*/
|
||||
ipoctal->dev->bus->ops->request_irq(ipoctal->dev,
|
||||
ipoctal_irq_handler, ipoctal);
|
||||
/* Dummy write */
|
||||
iowrite8(1, ipoctal->mem8_space + 1);
|
||||
|
||||
|
@ -390,6 +383,14 @@ static int ipoctal_inst_slot(struct ipoctal *ipoctal, unsigned int bus_nr,
|
|||
dev_set_drvdata(tty_dev, channel);
|
||||
}
|
||||
|
||||
/*
|
||||
* IP-OCTAL has different addresses to copy its IRQ vector.
|
||||
* Depending of the carrier these addresses are accesible or not.
|
||||
* More info in the datasheet.
|
||||
*/
|
||||
ipoctal->dev->bus->ops->request_irq(ipoctal->dev,
|
||||
ipoctal_irq_handler, ipoctal);
|
||||
|
||||
return 0;
|
||||
}
|
||||
|
||||
|
|
Загрузка…
Ссылка в новой задаче