dmaengine/amba-pl08x: Simplify pl08x_ensure_on()
Simply writing 1 on bit 0 is sufficient instead of reading and clearing bits. Also as per manual, for bit 3-31 of DMACConfiguration register: "read undefined, write as 0" So, we must not rely on values read from this registers bit 3-31. Signed-off-by: Viresh Kumar <viresh.kumar@st.com> Acked-by: Linus Walleij <linus.walleij@linaro.org> Signed-off-by: Vinod Koul <vinod.koul@intel.com>
This commit is contained in:
Родитель
b7b6018bad
Коммит
48a59ef357
|
@ -1502,13 +1502,7 @@ bool pl08x_filter_id(struct dma_chan *chan, void *chan_id)
|
||||||
*/
|
*/
|
||||||
static void pl08x_ensure_on(struct pl08x_driver_data *pl08x)
|
static void pl08x_ensure_on(struct pl08x_driver_data *pl08x)
|
||||||
{
|
{
|
||||||
u32 val;
|
writel(PL080_CONFIG_ENABLE, pl08x->base + PL080_CONFIG);
|
||||||
|
|
||||||
val = readl(pl08x->base + PL080_CONFIG);
|
|
||||||
val &= ~(PL080_CONFIG_M2_BE | PL080_CONFIG_M1_BE | PL080_CONFIG_ENABLE);
|
|
||||||
/* We implicitly clear bit 1 and that means little-endian mode */
|
|
||||||
val |= PL080_CONFIG_ENABLE;
|
|
||||||
writel(val, pl08x->base + PL080_CONFIG);
|
|
||||||
}
|
}
|
||||||
|
|
||||||
static void pl08x_unmap_buffers(struct pl08x_txd *txd)
|
static void pl08x_unmap_buffers(struct pl08x_txd *txd)
|
||||||
|
|
Загрузка…
Ссылка в новой задаче