xen-scsiback: clean up a type issue in scsiback_make_tpg()
This code was confusing because we had an unsigned long and then we compared it to UINT_MAX and then we stored it in a u16. How many bytes is this supposed to have: 2, 4 or 16??? I've made it a u16 throughout. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Reviewed-by: Juergen Gross <jgross@suse.com> Signed-off-by: David Vrabel <david.vrabel@citrix.com>
This commit is contained in:
Родитель
d9b1e6374b
Коммит
495daef902
|
@ -1885,13 +1885,14 @@ scsiback_make_tpg(struct se_wwn *wwn,
|
||||||
struct scsiback_tport, tport_wwn);
|
struct scsiback_tport, tport_wwn);
|
||||||
|
|
||||||
struct scsiback_tpg *tpg;
|
struct scsiback_tpg *tpg;
|
||||||
unsigned long tpgt;
|
u16 tpgt;
|
||||||
int ret;
|
int ret;
|
||||||
|
|
||||||
if (strstr(name, "tpgt_") != name)
|
if (strstr(name, "tpgt_") != name)
|
||||||
return ERR_PTR(-EINVAL);
|
return ERR_PTR(-EINVAL);
|
||||||
if (kstrtoul(name + 5, 10, &tpgt) || tpgt > UINT_MAX)
|
ret = kstrtou16(name + 5, 10, &tpgt);
|
||||||
return ERR_PTR(-EINVAL);
|
if (ret)
|
||||||
|
return ERR_PTR(ret);
|
||||||
|
|
||||||
tpg = kzalloc(sizeof(struct scsiback_tpg), GFP_KERNEL);
|
tpg = kzalloc(sizeof(struct scsiback_tpg), GFP_KERNEL);
|
||||||
if (!tpg)
|
if (!tpg)
|
||||||
|
|
Загрузка…
Ссылка в новой задаче