drivers/misc/sgi-gru/grukdump.c: unlocking should be conditional in gru_dump_context()
I was reviewing this and noticed that unlocking should be conditional on the error path. I've changed it to unlock and return directly since we only do it once and it seems unlikely to change in the near future. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Acked-by: Dimitri Sivanich <sivanich@sgi.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Родитель
b28a960c42
Коммит
49d3d6c37a
|
@ -139,8 +139,11 @@ static int gru_dump_context(struct gru_state *gru, int ctxnum,
|
|||
|
||||
ubuf += sizeof(hdr);
|
||||
ubufcch = ubuf;
|
||||
if (gru_user_copy_handle(&ubuf, cch))
|
||||
goto fail;
|
||||
if (gru_user_copy_handle(&ubuf, cch)) {
|
||||
if (cch_locked)
|
||||
unlock_cch_handle(cch);
|
||||
return -EFAULT;
|
||||
}
|
||||
if (cch_locked)
|
||||
ubufcch->delresp = 0;
|
||||
bytes = sizeof(hdr) + GRU_CACHE_LINE_BYTES;
|
||||
|
@ -179,10 +182,6 @@ static int gru_dump_context(struct gru_state *gru, int ctxnum,
|
|||
ret = -EFAULT;
|
||||
|
||||
return ret ? ret : bytes;
|
||||
|
||||
fail:
|
||||
unlock_cch_handle(cch);
|
||||
return -EFAULT;
|
||||
}
|
||||
|
||||
int gru_dump_chiplet_request(unsigned long arg)
|
||||
|
|
Загрузка…
Ссылка в новой задаче