ALSA: aoa: i2sbus: fix possible memory leak in i2sbus_add_dev()
dev_set_name() in soundbus_add_one() allocates memory for name, it need be
freed when of_device_register() fails, call soundbus_dev_put() to give up
the reference that hold in device_initialize(), so that it can be freed in
kobject_cleanup() when the refcount hit to 0. And other resources are also
freed in i2sbus_release_dev(), so it can return 0 directly.
Fixes: f3d9478b2c
("[ALSA] snd-aoa: add snd-aoa")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Link: https://lore.kernel.org/r/20221027013438.991920-1-yangyingliang@huawei.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
This commit is contained in:
Родитель
f850a2b156
Коммит
4a4c8482e3
|
@ -302,6 +302,10 @@ static int i2sbus_add_dev(struct macio_dev *macio,
|
|||
|
||||
if (soundbus_add_one(&dev->sound)) {
|
||||
printk(KERN_DEBUG "i2sbus: device registration error!\n");
|
||||
if (dev->sound.ofdev.dev.kobj.state_initialized) {
|
||||
soundbus_dev_put(&dev->sound);
|
||||
return 0;
|
||||
}
|
||||
goto err;
|
||||
}
|
||||
|
||||
|
|
Загрузка…
Ссылка в новой задаче