xfs: lock rt summary inode on allocation
RT allocation can fail on a debug kernel with: XFS: Assertion failed: xfs_isilocked(ip, XFS_ILOCK_SHARED|XFS_ILOCK_EXCL), file: fs/xfs/libxfs/xfs_bmap.c, line: 4039 When modifying the summary inode during allocation. This occurs because the summary inode is never locked, and xfs_bmapi_* operations expect it to be locked. The summary inode is effectively protected byt he lock on the bitmap inode, so this really is only a debug kernel issue. Signed-off-by: Dave Chinner <dchinner@redhat.com> Tested-by: Ross Zwisler <ross.zwisler@linux.intel.com> Reviewed-by: Eric Sandeen <sandeen@redhat.com> Signed-off-by: Dave Chinner <david@fromorbit.com>
This commit is contained in:
Родитель
36f90b0a2d
Коммит
4b680afb42
|
@ -202,10 +202,12 @@ xfs_bmap_rtalloc(
|
|||
ralen = MAXEXTLEN / mp->m_sb.sb_rextsize;
|
||||
|
||||
/*
|
||||
* Lock out other modifications to the RT bitmap inode.
|
||||
* Lock out modifications to both the RT bitmap and summary inodes
|
||||
*/
|
||||
xfs_ilock(mp->m_rbmip, XFS_ILOCK_EXCL);
|
||||
xfs_trans_ijoin(ap->tp, mp->m_rbmip, XFS_ILOCK_EXCL);
|
||||
xfs_ilock(mp->m_rsumip, XFS_ILOCK_EXCL);
|
||||
xfs_trans_ijoin(ap->tp, mp->m_rsumip, XFS_ILOCK_EXCL);
|
||||
|
||||
/*
|
||||
* If it's an allocation to an empty file at offset 0,
|
||||
|
|
Загрузка…
Ссылка в новой задаче