media: rkisp1: Use correct macro for gradient registers
The rkisp1_lsc_config() function incorrectly uses the RKISP1_CIF_ISP_LSC_SECT_SIZE() macro for the gradient registers. Replace it with the correct macro, and rename it from RKISP1_CIF_ISP_LSC_GRAD_SIZE() to RKISP1_CIF_ISP_LSC_SECT_GRAD() as the corresponding registers store the gradients for each sector, not a size. This doesn't cause any functional change as the two macros are defined identically (the size and gradient registers store fields in the same number of bits at the same positions). Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Dafna Hirschfeld <dafna@fastmail.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
This commit is contained in:
Родитель
10e36b2191
Коммит
4c3501f13e
|
@ -334,7 +334,7 @@ static void rkisp1_lsc_config(struct rkisp1_params *params,
|
|||
rkisp1_write(rkisp1, RKISP1_CIF_ISP_LSC_XSIZE(i), data);
|
||||
|
||||
/* program x grad tables */
|
||||
data = RKISP1_CIF_ISP_LSC_SECT_SIZE(arg->x_grad_tbl[i * 2],
|
||||
data = RKISP1_CIF_ISP_LSC_SECT_GRAD(arg->x_grad_tbl[i * 2],
|
||||
arg->x_grad_tbl[i * 2 + 1]);
|
||||
rkisp1_write(rkisp1, RKISP1_CIF_ISP_LSC_XGRAD(i), data);
|
||||
|
||||
|
@ -344,7 +344,7 @@ static void rkisp1_lsc_config(struct rkisp1_params *params,
|
|||
rkisp1_write(rkisp1, RKISP1_CIF_ISP_LSC_YSIZE(i), data);
|
||||
|
||||
/* program y grad tables */
|
||||
data = RKISP1_CIF_ISP_LSC_SECT_SIZE(arg->y_grad_tbl[i * 2],
|
||||
data = RKISP1_CIF_ISP_LSC_SECT_GRAD(arg->y_grad_tbl[i * 2],
|
||||
arg->y_grad_tbl[i * 2 + 1]);
|
||||
rkisp1_write(rkisp1, RKISP1_CIF_ISP_LSC_YGRAD(i), data);
|
||||
}
|
||||
|
|
|
@ -576,7 +576,7 @@
|
|||
(((v0) & 0x1FFF) | (((v1) & 0x1FFF) << 13))
|
||||
#define RKISP1_CIF_ISP_LSC_SECT_SIZE(v0, v1) \
|
||||
(((v0) & 0xFFF) | (((v1) & 0xFFF) << 16))
|
||||
#define RKISP1_CIF_ISP_LSC_GRAD_SIZE(v0, v1) \
|
||||
#define RKISP1_CIF_ISP_LSC_SECT_GRAD(v0, v1) \
|
||||
(((v0) & 0xFFF) | (((v1) & 0xFFF) << 16))
|
||||
|
||||
/* LSC: ISP_LSC_TABLE_SEL */
|
||||
|
|
Загрузка…
Ссылка в новой задаче