mtd: rawnand: silence static checker warning in nand_setup_interface()
Smatch complains that the error code is not set on this error path: drivers/mtd/nand/raw/nand_base.c:842 nand_setup_interface() warn: missing error code 'ret' But actually returning success is intentional because the NAND chip will still work in mode 0. This patch adds a "ret = 0;" assignment to make the intent more clear and to silence the static checker warning. It doesn't affect the compiled code because GCC optimises the assignment away. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> Link: https://lore.kernel.org/linux-mtd/YH6Ugwz3gcga+q8X@mwanda
This commit is contained in:
Родитель
e101bd3045
Коммит
4d888eceb7
|
@ -880,6 +880,7 @@ static int nand_setup_interface(struct nand_chip *chip, int chipnr)
|
|||
if (tmode_param[0] != chip->best_interface_config->timings.mode) {
|
||||
pr_warn("timing mode %d not acknowledged by the NAND chip\n",
|
||||
chip->best_interface_config->timings.mode);
|
||||
ret = 0;
|
||||
goto err_reset_chip;
|
||||
}
|
||||
|
||||
|
|
Загрузка…
Ссылка в новой задаче