net: dp83869: Reset return variable if PHY strap is read
When the PHY's strap register is read to determine if lane swapping is
needed the phy_read_mmd returns the value back into the ret variable.
If the call to read the strap fails the failed value is returned. If
the call to read the strap is successful then ret is possibly set to a
non-zero positive number. Without reseting the ret value to 0 this will
cause the parse DT function to return a failure.
Fixes: c4566aec6e
("net: phy: dp83869: Update port-mirroring to read straps")
Signed-off-by: Dan Murphy <dmurphy@ti.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Родитель
4a3084aaa8
Коммит
4e2905adac
|
@ -218,10 +218,13 @@ static int dp83869_of_init(struct phy_device *phydev)
|
|||
ret = phy_read_mmd(phydev, DP83869_DEVADDR, DP83869_STRAP_STS1);
|
||||
if (ret < 0)
|
||||
return ret;
|
||||
|
||||
if (ret & DP83869_STRAP_MIRROR_ENABLED)
|
||||
dp83869->port_mirroring = DP83869_PORT_MIRRORING_EN;
|
||||
else
|
||||
dp83869->port_mirroring = DP83869_PORT_MIRRORING_DIS;
|
||||
|
||||
ret = 0;
|
||||
}
|
||||
|
||||
if (of_property_read_u32(of_node, "rx-fifo-depth",
|
||||
|
|
Загрузка…
Ссылка в новой задаче