usb: limit OMAP related USB options to OMAP2PLUS platforms
commit57f6ce072e
("usb: phy: add a new driver for usb3 phy") added the new Kconfig option OMAP_USB3, but it had no dependencies whatsoever, and hence became available across all arch/platforms. Which presumably caused this to show up in x86 randconfig: warning: (USB_MUSB_HDRC && OMAP_USB3) selects \ OMAP_CONTROL_USB which has unmet direct \ dependencies (USB_SUPPORT && ARCH_OMAP2PLUS) Then commit6992819feb
("usb: phy: fix Kconfig warning") was added. However, this just deleted the ARCH_OMAP2PLUS dependency from OMAP_CONTROL_USB, further compounding the problem by opening up OMAP_CONTROL_USB to all arch/platforms as well. Earlier it was suggested[1] that we revert the change of6992819feb
to restore the dependency, and add a same ARCH_OMAP2PLUS dependency to the new OMAP_USB3 entry. However that was discouraged on the grounds of people wanting the extra sanity compile testing on x86, even though the driver could probably never be used there. Now we have CONFIG_COMPILE_TEST, so developers who value the ability to compile drivers on an architecture that it never can be used for can have that, and people who want dependencies to shield them from seeing options that aren't relevant to their platform get what they want too. Here we restore the dependency but couple it with COMPILE_TEST, in order to achieve both of the above goals. [1] https://patchwork.kernel.org/patch/2194511/ Acked-by: Felipe Balbi <balbi@ti.com> Cc: Kishon Vijay Abraham I <kishon@ti.com> Cc: Moiz Sonasath <m-sonasath@ti.com> Cc: Jiri Slaby <jslaby@suse.cz> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Родитель
af3f233fd2
Коммит
4e682bbd32
|
@ -65,6 +65,7 @@ config NOP_USB_XCEIV
|
||||||
|
|
||||||
config OMAP_CONTROL_USB
|
config OMAP_CONTROL_USB
|
||||||
tristate "OMAP CONTROL USB Driver"
|
tristate "OMAP CONTROL USB Driver"
|
||||||
|
depends on ARCH_OMAP2PLUS || COMPILE_TEST
|
||||||
help
|
help
|
||||||
Enable this to add support for the USB part present in the control
|
Enable this to add support for the USB part present in the control
|
||||||
module. This driver has API to power on the USB2 PHY and to write to
|
module. This driver has API to power on the USB2 PHY and to write to
|
||||||
|
@ -84,6 +85,7 @@ config OMAP_USB2
|
||||||
|
|
||||||
config OMAP_USB3
|
config OMAP_USB3
|
||||||
tristate "OMAP USB3 PHY Driver"
|
tristate "OMAP USB3 PHY Driver"
|
||||||
|
depends on ARCH_OMAP2PLUS || COMPILE_TEST
|
||||||
select OMAP_CONTROL_USB
|
select OMAP_CONTROL_USB
|
||||||
help
|
help
|
||||||
Enable this to support the USB3 PHY that is part of SOC. This
|
Enable this to support the USB3 PHY that is part of SOC. This
|
||||||
|
|
Загрузка…
Ссылка в новой задаче