[PATCH] Fix smsc_ircc_init return value
I noticed a strange return value in smsc_ircc_init in drivers/net/irda/smsc_ircc2.c in rc4-mm1. When reaching the line "if (ircc_fir > 0 && ircc_sir > 0)", ret is 0. So I don't see the point of setting it to 0 in the "else" case. >From what I see in 2.6.12 it should probably be set to -ENODEV at the begining of the "else" case. The attached patch does this. Note that I didn't actually see any breakage caused by this. Signed-off-by: Brice Goglin <Brice.Goglin@ens-lyon.org> Cc: Dmitry Torokhov <dtor_core@ameritech.net> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
This commit is contained in:
Родитель
0fa2f491f0
Коммит
505db03639
|
@ -360,6 +360,7 @@ static int __init smsc_ircc_init(void)
|
||||||
if (smsc_ircc_open(ircc_fir, ircc_sir, ircc_dma, ircc_irq))
|
if (smsc_ircc_open(ircc_fir, ircc_sir, ircc_dma, ircc_irq))
|
||||||
ret = -ENODEV;
|
ret = -ENODEV;
|
||||||
} else {
|
} else {
|
||||||
|
ret = -ENODEV;
|
||||||
|
|
||||||
/* try user provided configuration register base address */
|
/* try user provided configuration register base address */
|
||||||
if (ircc_cfg > 0) {
|
if (ircc_cfg > 0) {
|
||||||
|
|
Загрузка…
Ссылка в новой задаче