VFIO fixes for v4.5-rc7
- Use -EFAULT for copy_to_user error in ioctl (Michael Tsirkin) -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (GNU/Linux) iQIcBAABAgAGBQJW2DJhAAoJECObm247sIsiJTsQAIi3+YtDniobxNqGSGlevqp+ Dyx1FTNpu1k7Pc82+7lQkL95+WL5Xi6UevyrKXpKP3GjTbMC+1MgnHRnitweRwNM lTfLkep7/ExPazWLQ/+UYRBds+WjdTgQpc5DHorN/Ole3oIvizOT3+gqwEpfAW4Z enO+TjoQFWPZMg5JVNmZ/s5t+KYtavPXMlTvwOd09bLDpIgbMSZb6P+vsVWdBVi3 fLfCXsSfIOETq7vcpMJFZiX9VjSz5xpiLhnZbjz90tWdy1rL9aP9ocrixoPecSbp RWe4tzlCtNOaoGliuhYoImgTp/mJAxsxv8qdGYeLf+vElufcB0mu16lmRxmTR7Xr WjHsRfcN3cvdIK06XMwgegmin8Xyqlk+nXo6oD1x3OdU1pgggI9gGMBZgR+2hvuQ Sp1Q8wPXc5MrcFefK9dN/2Pl94XaZ9VODX7QJ7HFl24Rp0RqF0ERo1vcRHEGb8Wn v4PW6GhbaAAu8PBiAuCUpFJM1SJgr2ZLfAeGyNvOEahcslYV73/UApWocIdjTva1 YjxJaw32OaMhcMTgz+zA+uH6QfSS25Tl5M7vsWM8tdtDsQKKl+TolyhaWM5rLehJ vy80ISXSRL87bHaqPTCNWSEaNseCP0pQZXdqIRsIeQftHyyLZQm/6Sl2W1DFLmtK lxB/HUrFJQlZpNe/iO1t =cYvr -----END PGP SIGNATURE----- Merge tag 'vfio-v4.5-rc7' of git://github.com/awilliam/linux-vfio Pull VFIO fix from Alex Williamson: "Use -EFAULT for copy_to_user error in ioctl (Michael Tsirkin)" * tag 'vfio-v4.5-rc7' of git://github.com/awilliam/linux-vfio: vfio: fix ioctl error handling
This commit is contained in:
Коммит
52ad12966b
|
@ -446,7 +446,8 @@ static long vfio_pci_ioctl(void *device_data,
|
||||||
info.num_regions = VFIO_PCI_NUM_REGIONS;
|
info.num_regions = VFIO_PCI_NUM_REGIONS;
|
||||||
info.num_irqs = VFIO_PCI_NUM_IRQS;
|
info.num_irqs = VFIO_PCI_NUM_IRQS;
|
||||||
|
|
||||||
return copy_to_user((void __user *)arg, &info, minsz);
|
return copy_to_user((void __user *)arg, &info, minsz) ?
|
||||||
|
-EFAULT : 0;
|
||||||
|
|
||||||
} else if (cmd == VFIO_DEVICE_GET_REGION_INFO) {
|
} else if (cmd == VFIO_DEVICE_GET_REGION_INFO) {
|
||||||
struct pci_dev *pdev = vdev->pdev;
|
struct pci_dev *pdev = vdev->pdev;
|
||||||
|
@ -520,7 +521,8 @@ static long vfio_pci_ioctl(void *device_data,
|
||||||
return -EINVAL;
|
return -EINVAL;
|
||||||
}
|
}
|
||||||
|
|
||||||
return copy_to_user((void __user *)arg, &info, minsz);
|
return copy_to_user((void __user *)arg, &info, minsz) ?
|
||||||
|
-EFAULT : 0;
|
||||||
|
|
||||||
} else if (cmd == VFIO_DEVICE_GET_IRQ_INFO) {
|
} else if (cmd == VFIO_DEVICE_GET_IRQ_INFO) {
|
||||||
struct vfio_irq_info info;
|
struct vfio_irq_info info;
|
||||||
|
@ -555,7 +557,8 @@ static long vfio_pci_ioctl(void *device_data,
|
||||||
else
|
else
|
||||||
info.flags |= VFIO_IRQ_INFO_NORESIZE;
|
info.flags |= VFIO_IRQ_INFO_NORESIZE;
|
||||||
|
|
||||||
return copy_to_user((void __user *)arg, &info, minsz);
|
return copy_to_user((void __user *)arg, &info, minsz) ?
|
||||||
|
-EFAULT : 0;
|
||||||
|
|
||||||
} else if (cmd == VFIO_DEVICE_SET_IRQS) {
|
} else if (cmd == VFIO_DEVICE_SET_IRQS) {
|
||||||
struct vfio_irq_set hdr;
|
struct vfio_irq_set hdr;
|
||||||
|
|
|
@ -219,7 +219,8 @@ static long vfio_platform_ioctl(void *device_data,
|
||||||
info.num_regions = vdev->num_regions;
|
info.num_regions = vdev->num_regions;
|
||||||
info.num_irqs = vdev->num_irqs;
|
info.num_irqs = vdev->num_irqs;
|
||||||
|
|
||||||
return copy_to_user((void __user *)arg, &info, minsz);
|
return copy_to_user((void __user *)arg, &info, minsz) ?
|
||||||
|
-EFAULT : 0;
|
||||||
|
|
||||||
} else if (cmd == VFIO_DEVICE_GET_REGION_INFO) {
|
} else if (cmd == VFIO_DEVICE_GET_REGION_INFO) {
|
||||||
struct vfio_region_info info;
|
struct vfio_region_info info;
|
||||||
|
@ -240,7 +241,8 @@ static long vfio_platform_ioctl(void *device_data,
|
||||||
info.size = vdev->regions[info.index].size;
|
info.size = vdev->regions[info.index].size;
|
||||||
info.flags = vdev->regions[info.index].flags;
|
info.flags = vdev->regions[info.index].flags;
|
||||||
|
|
||||||
return copy_to_user((void __user *)arg, &info, minsz);
|
return copy_to_user((void __user *)arg, &info, minsz) ?
|
||||||
|
-EFAULT : 0;
|
||||||
|
|
||||||
} else if (cmd == VFIO_DEVICE_GET_IRQ_INFO) {
|
} else if (cmd == VFIO_DEVICE_GET_IRQ_INFO) {
|
||||||
struct vfio_irq_info info;
|
struct vfio_irq_info info;
|
||||||
|
@ -259,7 +261,8 @@ static long vfio_platform_ioctl(void *device_data,
|
||||||
info.flags = vdev->irqs[info.index].flags;
|
info.flags = vdev->irqs[info.index].flags;
|
||||||
info.count = vdev->irqs[info.index].count;
|
info.count = vdev->irqs[info.index].count;
|
||||||
|
|
||||||
return copy_to_user((void __user *)arg, &info, minsz);
|
return copy_to_user((void __user *)arg, &info, minsz) ?
|
||||||
|
-EFAULT : 0;
|
||||||
|
|
||||||
} else if (cmd == VFIO_DEVICE_SET_IRQS) {
|
} else if (cmd == VFIO_DEVICE_SET_IRQS) {
|
||||||
struct vfio_irq_set hdr;
|
struct vfio_irq_set hdr;
|
||||||
|
|
|
@ -999,7 +999,8 @@ static long vfio_iommu_type1_ioctl(void *iommu_data,
|
||||||
|
|
||||||
info.iova_pgsizes = vfio_pgsize_bitmap(iommu);
|
info.iova_pgsizes = vfio_pgsize_bitmap(iommu);
|
||||||
|
|
||||||
return copy_to_user((void __user *)arg, &info, minsz);
|
return copy_to_user((void __user *)arg, &info, minsz) ?
|
||||||
|
-EFAULT : 0;
|
||||||
|
|
||||||
} else if (cmd == VFIO_IOMMU_MAP_DMA) {
|
} else if (cmd == VFIO_IOMMU_MAP_DMA) {
|
||||||
struct vfio_iommu_type1_dma_map map;
|
struct vfio_iommu_type1_dma_map map;
|
||||||
|
@ -1032,7 +1033,8 @@ static long vfio_iommu_type1_ioctl(void *iommu_data,
|
||||||
if (ret)
|
if (ret)
|
||||||
return ret;
|
return ret;
|
||||||
|
|
||||||
return copy_to_user((void __user *)arg, &unmap, minsz);
|
return copy_to_user((void __user *)arg, &unmap, minsz) ?
|
||||||
|
-EFAULT : 0;
|
||||||
}
|
}
|
||||||
|
|
||||||
return -ENOTTY;
|
return -ENOTTY;
|
||||||
|
|
Загрузка…
Ссылка в новой задаче