perf hists: Introduce output_resort_cb method

When dealing with nested hist entries it's helpful to have a way to
resort those nested objects.

Adding optional callback call into output_resort function and following
new interface function:

  typedef int (*hists__resort_cb_t)(struct hist_entry *he);

  void hists__output_resort_cb(struct hists *hists,
                               struct ui_progress *prog,
                               hists__resort_cb_t cb);

Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Cc: David Ahern <dsahern@gmail.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1470074555-24889-7-git-send-email-jolsa@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
This commit is contained in:
Jiri Olsa 2016-08-01 20:02:34 +02:00 коммит произвёл Arnaldo Carvalho de Melo
Родитель 4842576cd8
Коммит 52c5cc363f
2 изменённых файлов: 16 добавлений и 3 удалений

Просмотреть файл

@ -1672,7 +1672,7 @@ static void __hists__insert_output_entry(struct rb_root *entries,
} }
static void output_resort(struct hists *hists, struct ui_progress *prog, static void output_resort(struct hists *hists, struct ui_progress *prog,
bool use_callchain) bool use_callchain, hists__resort_cb_t cb)
{ {
struct rb_root *root; struct rb_root *root;
struct rb_node *next; struct rb_node *next;
@ -1711,6 +1711,9 @@ static void output_resort(struct hists *hists, struct ui_progress *prog,
n = rb_entry(next, struct hist_entry, rb_node_in); n = rb_entry(next, struct hist_entry, rb_node_in);
next = rb_next(&n->rb_node_in); next = rb_next(&n->rb_node_in);
if (cb && cb(n))
continue;
__hists__insert_output_entry(&hists->entries, n, min_callchain_hits, use_callchain); __hists__insert_output_entry(&hists->entries, n, min_callchain_hits, use_callchain);
hists__inc_stats(hists, n); hists__inc_stats(hists, n);
@ -1731,12 +1734,18 @@ void perf_evsel__output_resort(struct perf_evsel *evsel, struct ui_progress *pro
else else
use_callchain = symbol_conf.use_callchain; use_callchain = symbol_conf.use_callchain;
output_resort(evsel__hists(evsel), prog, use_callchain); output_resort(evsel__hists(evsel), prog, use_callchain, NULL);
} }
void hists__output_resort(struct hists *hists, struct ui_progress *prog) void hists__output_resort(struct hists *hists, struct ui_progress *prog)
{ {
output_resort(hists, prog, symbol_conf.use_callchain); output_resort(hists, prog, symbol_conf.use_callchain, NULL);
}
void hists__output_resort_cb(struct hists *hists, struct ui_progress *prog,
hists__resort_cb_t cb)
{
output_resort(hists, prog, symbol_conf.use_callchain, cb);
} }
static bool can_goto_child(struct hist_entry *he, enum hierarchy_move_dir hmd) static bool can_goto_child(struct hist_entry *he, enum hierarchy_move_dir hmd)

Просмотреть файл

@ -153,8 +153,12 @@ int hist_entry__snprintf_alignment(struct hist_entry *he, struct perf_hpp *hpp,
struct perf_hpp_fmt *fmt, int printed); struct perf_hpp_fmt *fmt, int printed);
void hist_entry__delete(struct hist_entry *he); void hist_entry__delete(struct hist_entry *he);
typedef int (*hists__resort_cb_t)(struct hist_entry *he);
void perf_evsel__output_resort(struct perf_evsel *evsel, struct ui_progress *prog); void perf_evsel__output_resort(struct perf_evsel *evsel, struct ui_progress *prog);
void hists__output_resort(struct hists *hists, struct ui_progress *prog); void hists__output_resort(struct hists *hists, struct ui_progress *prog);
void hists__output_resort_cb(struct hists *hists, struct ui_progress *prog,
hists__resort_cb_t cb);
int hists__collapse_resort(struct hists *hists, struct ui_progress *prog); int hists__collapse_resort(struct hists *hists, struct ui_progress *prog);
void hists__decay_entries(struct hists *hists, bool zap_user, bool zap_kernel); void hists__decay_entries(struct hists *hists, bool zap_user, bool zap_kernel);