Btrfs: ensure path name is null terminated at btrfs_control_ioctl
commit f505754fd6
upstream.
We were using the path name received from user space without checking that
it is null terminated. While btrfs-progs is well behaved and does proper
validation and null termination, someone could call the ioctl and pass
a non-null terminated patch, leading to buffer overrun problems in the
kernel. The ioctl is protected by CAP_SYS_ADMIN.
So just set the last byte of the path to a null character, similar to what
we do in other ioctls (add/remove/resize device, snapshot creation, etc).
CC: stable@vger.kernel.org # 4.4+
Reviewed-by: Anand Jain <anand.jain@oracle.com>
Signed-off-by: Filipe Manana <fdmanana@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Родитель
d36e4ee3b3
Коммит
52fa8eaac8
|
@ -2176,6 +2176,7 @@ static long btrfs_control_ioctl(struct file *file, unsigned int cmd,
|
||||||
vol = memdup_user((void __user *)arg, sizeof(*vol));
|
vol = memdup_user((void __user *)arg, sizeof(*vol));
|
||||||
if (IS_ERR(vol))
|
if (IS_ERR(vol))
|
||||||
return PTR_ERR(vol);
|
return PTR_ERR(vol);
|
||||||
|
vol->name[BTRFS_PATH_NAME_MAX] = '\0';
|
||||||
|
|
||||||
switch (cmd) {
|
switch (cmd) {
|
||||||
case BTRFS_IOC_SCAN_DEV:
|
case BTRFS_IOC_SCAN_DEV:
|
||||||
|
|
Загрузка…
Ссылка в новой задаче