ASoC: sh: rcar: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> Acked-by: Takashi Iwai <tiwai@suse.de> Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com> Link: https://lore.kernel.org/r/20230315150745.67084-133-u.kleine-koenig@pengutronix.de Signed-off-by: Mark Brown <broonie@kernel.org>
This commit is contained in:
Родитель
9baee32e88
Коммит
5310f0a331
|
@ -1987,7 +1987,7 @@ exit_snd_probe:
|
|||
return ret;
|
||||
}
|
||||
|
||||
static int rsnd_remove(struct platform_device *pdev)
|
||||
static void rsnd_remove(struct platform_device *pdev)
|
||||
{
|
||||
struct rsnd_priv *priv = dev_get_drvdata(&pdev->dev);
|
||||
struct rsnd_dai *rdai;
|
||||
|
@ -2019,8 +2019,6 @@ static int rsnd_remove(struct platform_device *pdev)
|
|||
|
||||
for (i = 0; i < ARRAY_SIZE(remove_func); i++)
|
||||
remove_func[i](priv);
|
||||
|
||||
return 0;
|
||||
}
|
||||
|
||||
static int __maybe_unused rsnd_suspend(struct device *dev)
|
||||
|
@ -2052,7 +2050,7 @@ static struct platform_driver rsnd_driver = {
|
|||
.of_match_table = rsnd_of_match,
|
||||
},
|
||||
.probe = rsnd_probe,
|
||||
.remove = rsnd_remove,
|
||||
.remove_new = rsnd_remove,
|
||||
};
|
||||
module_platform_driver(rsnd_driver);
|
||||
|
||||
|
|
Загрузка…
Ссылка в новой задаче