phylib: unsigneds go unnoticed
both pdata->mdc and pdata->mdio are unsigned. Notice a negative return value. Signed-off-by: Roel Kluin <roel.kluin@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Родитель
9f4d26d0f3
Коммит
57a574993d
|
@ -200,16 +200,21 @@ static int __devinit mdio_ofgpio_probe(struct of_device *ofdev,
|
|||
{
|
||||
struct device_node *np = NULL;
|
||||
struct mdio_gpio_platform_data *pdata;
|
||||
int ret;
|
||||
|
||||
pdata = kzalloc(sizeof(*pdata), GFP_KERNEL);
|
||||
if (!pdata)
|
||||
return -ENOMEM;
|
||||
|
||||
pdata->mdc = of_get_gpio(ofdev->node, 0);
|
||||
pdata->mdio = of_get_gpio(ofdev->node, 1);
|
||||
|
||||
if (pdata->mdc < 0 || pdata->mdio < 0)
|
||||
ret = of_get_gpio(ofdev->node, 0);
|
||||
if (ret < 0)
|
||||
goto out_free;
|
||||
pdata->mdc = ret;
|
||||
|
||||
ret = of_get_gpio(ofdev->node, 1);
|
||||
if (ret < 0)
|
||||
goto out_free;
|
||||
pdata->mdio = ret;
|
||||
|
||||
while ((np = of_get_next_child(ofdev->node, np)))
|
||||
if (!strcmp(np->type, "ethernet-phy"))
|
||||
|
|
Загрузка…
Ссылка в новой задаче