spi: pic32: fixup wait_for_completion_timeout return handling
wait_for_completion_timeout returns unsigned long not int so the check for <= 0 should be == 0 here. Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org> Signed-off-by: Mark Brown <broonie@kernel.org>
This commit is contained in:
Родитель
523d939ef9
Коммит
57c2b0ddd1
|
@ -507,6 +507,7 @@ static int pic32_spi_one_transfer(struct spi_master *master,
|
||||||
{
|
{
|
||||||
struct pic32_spi *pic32s;
|
struct pic32_spi *pic32s;
|
||||||
bool dma_issued = false;
|
bool dma_issued = false;
|
||||||
|
unsigned long timeout;
|
||||||
int ret;
|
int ret;
|
||||||
|
|
||||||
pic32s = spi_master_get_devdata(master);
|
pic32s = spi_master_get_devdata(master);
|
||||||
|
@ -553,8 +554,8 @@ static int pic32_spi_one_transfer(struct spi_master *master,
|
||||||
}
|
}
|
||||||
|
|
||||||
/* wait for completion */
|
/* wait for completion */
|
||||||
ret = wait_for_completion_timeout(&pic32s->xfer_done, 2 * HZ);
|
timeout = wait_for_completion_timeout(&pic32s->xfer_done, 2 * HZ);
|
||||||
if (ret <= 0) {
|
if (timeout == 0) {
|
||||||
dev_err(&spi->dev, "wait error/timedout\n");
|
dev_err(&spi->dev, "wait error/timedout\n");
|
||||||
if (dma_issued) {
|
if (dma_issued) {
|
||||||
dmaengine_terminate_all(master->dma_rx);
|
dmaengine_terminate_all(master->dma_rx);
|
||||||
|
|
Загрузка…
Ссылка в новой задаче