tty/serial: Migrate milbeaut_usio to use has_sysrq
The SUPPORT_SYSRQ ifdeffery is not nice as: - May create misunderstanding about sizeof(struct uart_port) between different objects - Prevents moving functions from serial_core.h - Reduces readability (well, it's ifdeffery - it's hard to follow) In order to remove SUPPORT_SYSRQ, has_sysrq variable has been added. Initialise it in driver's probe and remove ifdeffery. Signed-off-by: Dmitry Safonov <dima@arista.com> Link: https://lore.kernel.org/r/20191213000657.931618-23-dima@arista.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Родитель
dca3ac8d3b
Коммит
581a367e48
|
@ -3,10 +3,6 @@
|
|||
* Copyright (C) 2018 Socionext Inc.
|
||||
*/
|
||||
|
||||
#if defined(CONFIG_SERIAL_MILBEAUT_USIO_CONSOLE) && defined(CONFIG_MAGIC_SYSRQ)
|
||||
#define SUPPORT_SYSRQ
|
||||
#endif
|
||||
|
||||
#include <linux/clk.h>
|
||||
#include <linux/console.h>
|
||||
#include <linux/module.h>
|
||||
|
@ -537,6 +533,7 @@ static int mlb_usio_probe(struct platform_device *pdev)
|
|||
port->irq = mlb_usio_irq[index][RX];
|
||||
port->uartclk = clk_get_rate(clk);
|
||||
port->fifosize = 128;
|
||||
port->has_sysrq = IS_ENABLED(CONFIG_SERIAL_MILBEAUT_USIO_CONSOLE);
|
||||
port->iotype = UPIO_MEM32;
|
||||
port->flags = UPF_BOOT_AUTOCONF | UPF_SPD_VHI;
|
||||
port->line = index;
|
||||
|
|
Загрузка…
Ссылка в новой задаче