ALSA: echoaudio: Fix potential Oops in snd_echo_resume()
Freeing chip on error may lead to an Oops at the next time
the system goes to resume. Fix this by removing all
snd_echo_free() calls on error.
Fixes: 47b5d028fd
("ALSA: Echoaudio - Add suspend support #2")
Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
Link: https://lore.kernel.org/r/20200813074632.17022-1-dinghao.liu@zju.edu.cn
Signed-off-by: Takashi Iwai <tiwai@suse.de>
This commit is contained in:
Родитель
d96f27c80b
Коммит
5a25de6df7
|
@ -2212,7 +2212,6 @@ static int snd_echo_resume(struct device *dev)
|
|||
if (err < 0) {
|
||||
kfree(commpage_bak);
|
||||
dev_err(dev, "resume init_hw err=%d\n", err);
|
||||
snd_echo_free(chip);
|
||||
return err;
|
||||
}
|
||||
|
||||
|
@ -2239,7 +2238,6 @@ static int snd_echo_resume(struct device *dev)
|
|||
if (request_irq(pci->irq, snd_echo_interrupt, IRQF_SHARED,
|
||||
KBUILD_MODNAME, chip)) {
|
||||
dev_err(chip->card->dev, "cannot grab irq\n");
|
||||
snd_echo_free(chip);
|
||||
return -EBUSY;
|
||||
}
|
||||
chip->irq = pci->irq;
|
||||
|
|
Загрузка…
Ссылка в новой задаче