net: faraday: ftmac100: Use BUG_ON instead of if condition followed by BUG.
Notice that in this particular case unlikely() is already being called inside BUG_ON macro. This issue was detected with the help of Coccinelle. Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Родитель
4fa112f6b5
Коммит
5bca178eed
|
@ -402,6 +402,7 @@ static bool ftmac100_rx_packet(struct ftmac100 *priv, int *processed)
|
||||||
struct page *page;
|
struct page *page;
|
||||||
dma_addr_t map;
|
dma_addr_t map;
|
||||||
int length;
|
int length;
|
||||||
|
bool ret;
|
||||||
|
|
||||||
rxdes = ftmac100_rx_locate_first_segment(priv);
|
rxdes = ftmac100_rx_locate_first_segment(priv);
|
||||||
if (!rxdes)
|
if (!rxdes)
|
||||||
|
@ -416,8 +417,8 @@ static bool ftmac100_rx_packet(struct ftmac100 *priv, int *processed)
|
||||||
* It is impossible to get multi-segment packets
|
* It is impossible to get multi-segment packets
|
||||||
* because we always provide big enough receive buffers.
|
* because we always provide big enough receive buffers.
|
||||||
*/
|
*/
|
||||||
if (unlikely(!ftmac100_rxdes_last_segment(rxdes)))
|
ret = ftmac100_rxdes_last_segment(rxdes);
|
||||||
BUG();
|
BUG_ON(!ret);
|
||||||
|
|
||||||
/* start processing */
|
/* start processing */
|
||||||
skb = netdev_alloc_skb_ip_align(netdev, 128);
|
skb = netdev_alloc_skb_ip_align(netdev, 128);
|
||||||
|
|
Загрузка…
Ссылка в новой задаче