gpio: exar: Allocate resources on behalf of the platform device
Do not allocate resources on behalf of the parent device but on our own. Otherwise, cleanup does not properly work if gpio-exar is removed but not the parent device. Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com> Acked-by: Linus Walleij <linus.walleij@linaro.org> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
This commit is contained in:
Родитель
d3936d7437
Коммит
5dab5872e5
|
@ -139,7 +139,7 @@ static int gpio_exar_probe(struct platform_device *pdev)
|
|||
if (!p)
|
||||
return -ENOMEM;
|
||||
|
||||
exar_gpio = devm_kzalloc(&pcidev->dev, sizeof(*exar_gpio), GFP_KERNEL);
|
||||
exar_gpio = devm_kzalloc(&pdev->dev, sizeof(*exar_gpio), GFP_KERNEL);
|
||||
if (!exar_gpio)
|
||||
return -ENOMEM;
|
||||
|
||||
|
@ -160,7 +160,7 @@ static int gpio_exar_probe(struct platform_device *pdev)
|
|||
exar_gpio->regs = p;
|
||||
exar_gpio->index = index;
|
||||
|
||||
ret = devm_gpiochip_add_data(&pcidev->dev,
|
||||
ret = devm_gpiochip_add_data(&pdev->dev,
|
||||
&exar_gpio->gpio_chip, exar_gpio);
|
||||
if (ret)
|
||||
goto err_destroy;
|
||||
|
|
Загрузка…
Ссылка в новой задаче