ARM: S3C24XX: arch/arm/plat-s3c24xx: Move dereference after NULL test
If the NULL test on buf is needed, then the dereference should be after the NULL test. A simplified version of the semantic match that detects this problem is as follows (http://coccinelle.lip6.fr/): // <smpl> @match exists@ expression x, E; identifier fld; @@ * x->fld ... when != \(x = E\|&x\) * x == NULL // </smpl> Signed-off-by: Julia Lawall <julia@diku.dk> Signed-off-by: Ben Dooks <ben-linux@fluff.org>
This commit is contained in:
Родитель
d3bf3956c7
Коммит
60e5c1b5ec
|
@ -208,14 +208,14 @@ s3c2410_dma_loadbuffer(struct s3c2410_dma_chan *chan,
|
|||
{
|
||||
unsigned long reload;
|
||||
|
||||
pr_debug("s3c2410_chan_loadbuffer: loading buff %p (0x%08lx,0x%06x)\n",
|
||||
buf, (unsigned long)buf->data, buf->size);
|
||||
|
||||
if (buf == NULL) {
|
||||
dmawarn("buffer is NULL\n");
|
||||
return -EINVAL;
|
||||
}
|
||||
|
||||
pr_debug("s3c2410_chan_loadbuffer: loading buff %p (0x%08lx,0x%06x)\n",
|
||||
buf, (unsigned long)buf->data, buf->size);
|
||||
|
||||
/* check the state of the channel before we do anything */
|
||||
|
||||
if (chan->load_state == S3C2410_DMALOAD_1LOADED) {
|
||||
|
|
Загрузка…
Ссылка в новой задаче