watchdog: bcm63xx_wdt: use devm_ioremap_nocache()
Use devm_ioremap_nocache() to make cleanup paths simpler. Signed-off-by: Jingoo Han <jg1.han@samsung.com> Reviewed-by: Guenter Roeck <linux@roeck-us.net> Acked-by: Florian Fainelli <florian@openwrt.org> Signed-off-by: Wim Van Sebroeck <wim@iguana.be>
This commit is contained in:
Родитель
321e31231d
Коммит
626d65aa52
|
@ -16,6 +16,7 @@
|
||||||
#include <linux/errno.h>
|
#include <linux/errno.h>
|
||||||
#include <linux/fs.h>
|
#include <linux/fs.h>
|
||||||
#include <linux/init.h>
|
#include <linux/init.h>
|
||||||
|
#include <linux/io.h>
|
||||||
#include <linux/kernel.h>
|
#include <linux/kernel.h>
|
||||||
#include <linux/miscdevice.h>
|
#include <linux/miscdevice.h>
|
||||||
#include <linux/module.h>
|
#include <linux/module.h>
|
||||||
|
@ -249,7 +250,8 @@ static int bcm63xx_wdt_probe(struct platform_device *pdev)
|
||||||
return -ENODEV;
|
return -ENODEV;
|
||||||
}
|
}
|
||||||
|
|
||||||
bcm63xx_wdt_device.regs = ioremap_nocache(r->start, resource_size(r));
|
bcm63xx_wdt_device.regs = devm_ioremap_nocache(&pdev->dev, r->start,
|
||||||
|
resource_size(r));
|
||||||
if (!bcm63xx_wdt_device.regs) {
|
if (!bcm63xx_wdt_device.regs) {
|
||||||
dev_err(&pdev->dev, "failed to remap I/O resources\n");
|
dev_err(&pdev->dev, "failed to remap I/O resources\n");
|
||||||
return -ENXIO;
|
return -ENXIO;
|
||||||
|
@ -258,7 +260,7 @@ static int bcm63xx_wdt_probe(struct platform_device *pdev)
|
||||||
ret = bcm63xx_timer_register(TIMER_WDT_ID, bcm63xx_wdt_isr, NULL);
|
ret = bcm63xx_timer_register(TIMER_WDT_ID, bcm63xx_wdt_isr, NULL);
|
||||||
if (ret < 0) {
|
if (ret < 0) {
|
||||||
dev_err(&pdev->dev, "failed to register wdt timer isr\n");
|
dev_err(&pdev->dev, "failed to register wdt timer isr\n");
|
||||||
goto unmap;
|
return ret;
|
||||||
}
|
}
|
||||||
|
|
||||||
if (bcm63xx_wdt_settimeout(wdt_time)) {
|
if (bcm63xx_wdt_settimeout(wdt_time)) {
|
||||||
|
@ -281,8 +283,6 @@ static int bcm63xx_wdt_probe(struct platform_device *pdev)
|
||||||
|
|
||||||
unregister_timer:
|
unregister_timer:
|
||||||
bcm63xx_timer_unregister(TIMER_WDT_ID);
|
bcm63xx_timer_unregister(TIMER_WDT_ID);
|
||||||
unmap:
|
|
||||||
iounmap(bcm63xx_wdt_device.regs);
|
|
||||||
return ret;
|
return ret;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@ -293,7 +293,6 @@ static int bcm63xx_wdt_remove(struct platform_device *pdev)
|
||||||
|
|
||||||
misc_deregister(&bcm63xx_wdt_miscdev);
|
misc_deregister(&bcm63xx_wdt_miscdev);
|
||||||
bcm63xx_timer_unregister(TIMER_WDT_ID);
|
bcm63xx_timer_unregister(TIMER_WDT_ID);
|
||||||
iounmap(bcm63xx_wdt_device.regs);
|
|
||||||
return 0;
|
return 0;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
Загрузка…
Ссылка в новой задаче