cpufreq: s5pv210: Simplify with dev_err_probe()
Common pattern of handling deferred probe can be simplified with dev_err_probe(). Less code and also it prints the error value. Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
This commit is contained in:
Родитель
b89c01c960
Коммит
629238068e
|
@ -590,6 +590,7 @@ static struct notifier_block s5pv210_cpufreq_reboot_notifier = {
|
||||||
|
|
||||||
static int s5pv210_cpufreq_probe(struct platform_device *pdev)
|
static int s5pv210_cpufreq_probe(struct platform_device *pdev)
|
||||||
{
|
{
|
||||||
|
struct device *dev = &pdev->dev;
|
||||||
struct device_node *np;
|
struct device_node *np;
|
||||||
int id, result = 0;
|
int id, result = 0;
|
||||||
|
|
||||||
|
@ -602,21 +603,14 @@ static int s5pv210_cpufreq_probe(struct platform_device *pdev)
|
||||||
* cpufreq-dt driver.
|
* cpufreq-dt driver.
|
||||||
*/
|
*/
|
||||||
arm_regulator = regulator_get(NULL, "vddarm");
|
arm_regulator = regulator_get(NULL, "vddarm");
|
||||||
if (IS_ERR(arm_regulator)) {
|
if (IS_ERR(arm_regulator))
|
||||||
if (PTR_ERR(arm_regulator) == -EPROBE_DEFER)
|
return dev_err_probe(dev, PTR_ERR(arm_regulator),
|
||||||
pr_debug("vddarm regulator not ready, defer\n");
|
"failed to get regulator vddarm\n");
|
||||||
else
|
|
||||||
pr_err("failed to get regulator vddarm\n");
|
|
||||||
return PTR_ERR(arm_regulator);
|
|
||||||
}
|
|
||||||
|
|
||||||
int_regulator = regulator_get(NULL, "vddint");
|
int_regulator = regulator_get(NULL, "vddint");
|
||||||
if (IS_ERR(int_regulator)) {
|
if (IS_ERR(int_regulator)) {
|
||||||
if (PTR_ERR(int_regulator) == -EPROBE_DEFER)
|
result = dev_err_probe(dev, PTR_ERR(int_regulator),
|
||||||
pr_debug("vddint regulator not ready, defer\n");
|
"failed to get regulator vddint\n");
|
||||||
else
|
|
||||||
pr_err("failed to get regulator vddint\n");
|
|
||||||
result = PTR_ERR(int_regulator);
|
|
||||||
goto err_int_regulator;
|
goto err_int_regulator;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
Загрузка…
Ссылка в новой задаче