wireless: at76c50x: allocating too much data
This is a cut and paste mistake, sizeof(struct mib_local) was intended instead of sizeof(struct mib_phy). The call to at76_get_mib() uses sizeof(struct mib_local) correctly, although I changed that to sizeof(*m) for style reasons after discussion with some of the wireless maintainers. The current code works fine because mib_phy structs are larger than mib_local structs. But we may as well clean it up. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: John W. Linville <linville@tuxdriver.com>
This commit is contained in:
Родитель
8b5bed90a5
Коммит
62c50543ce
|
@ -1122,12 +1122,12 @@ exit:
|
|||
static void at76_dump_mib_local(struct at76_priv *priv)
|
||||
{
|
||||
int ret;
|
||||
struct mib_local *m = kmalloc(sizeof(struct mib_phy), GFP_KERNEL);
|
||||
struct mib_local *m = kmalloc(sizeof(*m), GFP_KERNEL);
|
||||
|
||||
if (!m)
|
||||
return;
|
||||
|
||||
ret = at76_get_mib(priv->udev, MIB_LOCAL, m, sizeof(struct mib_local));
|
||||
ret = at76_get_mib(priv->udev, MIB_LOCAL, m, sizeof(*m));
|
||||
if (ret < 0) {
|
||||
wiphy_err(priv->hw->wiphy,
|
||||
"at76_get_mib (LOCAL) failed: %d\n", ret);
|
||||
|
|
Загрузка…
Ссылка в новой задаче