pinctrl: single: fix potential NULL dereference in pcs_get_function()
commit 1c38a62f15e595346a1106025722869e87ffe044 upstream.
pinmux_generic_get_function() can return NULL and the pointer 'function'
was dereferenced without checking against NULL. Add checking of pointer
'function' in pcs_get_function().
Found by code review.
Cc: stable@vger.kernel.org
Fixes: 571aec4df5
("pinctrl: single: Use generic pinmux helpers for managing functions")
Signed-off-by: Ma Ke <make24@iscas.ac.cn>
Link: https://lore.kernel.org/20240808041355.2766009-1-make24@iscas.ac.cn
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Родитель
ce3c431c1f
Коммит
6341c28567
|
@ -350,6 +350,8 @@ static int pcs_get_function(struct pinctrl_dev *pctldev, unsigned pin,
|
||||||
return -ENOTSUPP;
|
return -ENOTSUPP;
|
||||||
fselector = setting->func;
|
fselector = setting->func;
|
||||||
function = pinmux_generic_get_function(pctldev, fselector);
|
function = pinmux_generic_get_function(pctldev, fselector);
|
||||||
|
if (!function)
|
||||||
|
return -EINVAL;
|
||||||
*func = function->data;
|
*func = function->data;
|
||||||
if (!(*func)) {
|
if (!(*func)) {
|
||||||
dev_err(pcs->dev, "%s could not find function%i\n",
|
dev_err(pcs->dev, "%s could not find function%i\n",
|
||||||
|
|
Загрузка…
Ссылка в новой задаче