From 644975179c00802936c5afc732d9df7f63f735a0 Mon Sep 17 00:00:00 2001 From: zhongbaisong Date: Wed, 7 Apr 2021 20:38:55 +0800 Subject: [PATCH] s390/protvirt: fix error return code in uv_info_init() Fix to return a negative error code from the error handling case instead of 0, as done elsewhere in this function. Reported-by: Hulk Robot Signed-off-by: Baisong Zhong Fixes: 37564ed834ac ("s390/uv: add prot virt guest/host indication files") Link: https://lore.kernel.org/r/2f7d62a4-3e75-b2b4-951b-75ef8ef59d16@huawei.com Signed-off-by: Heiko Carstens --- arch/s390/kernel/uv.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/arch/s390/kernel/uv.c b/arch/s390/kernel/uv.c index cbfbeab57c3b..370f664580af 100644 --- a/arch/s390/kernel/uv.c +++ b/arch/s390/kernel/uv.c @@ -460,8 +460,10 @@ static int __init uv_info_init(void) goto out_kobj; uv_query_kset = kset_create_and_add("query", NULL, uv_kobj); - if (!uv_query_kset) + if (!uv_query_kset) { + rc = -ENOMEM; goto out_ind_files; + } rc = sysfs_create_group(&uv_query_kset->kobj, &uv_query_attr_group); if (!rc)