fujitsu-laptop: remove superfluous NULL pointer checks
This takes care of the following entries from Dan's list: drivers/platform/x86/fujitsu-laptop.c +327 set_lcd_level(13) warning: variable derefenced before check 'fujitsu' drivers/platform/x86/fujitsu-laptop.c +358 set_lcd_level_alt(13) warning: variable derefenced before check 'fujitsu' Reported-by: Dan Carpenter <error27@gmail.com> Cc: corbet@lwn.net Cc: eteo@redhat.com Cc: Julia Lawall <julia@diku.dk> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> Acked-by: Jonathan Woithe <jwoithe@physics.adelaide.edu.au> Signed-off-by: Len Brown <len.brown@intel.com>
This commit is contained in:
Родитель
14485c5727
Коммит
6705940621
|
@ -324,9 +324,6 @@ static int set_lcd_level(int level)
|
||||||
if (level < 0 || level >= fujitsu->max_brightness)
|
if (level < 0 || level >= fujitsu->max_brightness)
|
||||||
return -EINVAL;
|
return -EINVAL;
|
||||||
|
|
||||||
if (!fujitsu)
|
|
||||||
return -EINVAL;
|
|
||||||
|
|
||||||
status = acpi_get_handle(fujitsu->acpi_handle, "SBLL", &handle);
|
status = acpi_get_handle(fujitsu->acpi_handle, "SBLL", &handle);
|
||||||
if (ACPI_FAILURE(status)) {
|
if (ACPI_FAILURE(status)) {
|
||||||
vdbg_printk(FUJLAPTOP_DBG_ERROR, "SBLL not present\n");
|
vdbg_printk(FUJLAPTOP_DBG_ERROR, "SBLL not present\n");
|
||||||
|
@ -355,9 +352,6 @@ static int set_lcd_level_alt(int level)
|
||||||
if (level < 0 || level >= fujitsu->max_brightness)
|
if (level < 0 || level >= fujitsu->max_brightness)
|
||||||
return -EINVAL;
|
return -EINVAL;
|
||||||
|
|
||||||
if (!fujitsu)
|
|
||||||
return -EINVAL;
|
|
||||||
|
|
||||||
status = acpi_get_handle(fujitsu->acpi_handle, "SBL2", &handle);
|
status = acpi_get_handle(fujitsu->acpi_handle, "SBL2", &handle);
|
||||||
if (ACPI_FAILURE(status)) {
|
if (ACPI_FAILURE(status)) {
|
||||||
vdbg_printk(FUJLAPTOP_DBG_ERROR, "SBL2 not present\n");
|
vdbg_printk(FUJLAPTOP_DBG_ERROR, "SBL2 not present\n");
|
||||||
|
|
Загрузка…
Ссылка в новой задаче