net: ipa: don't thaw channel if error starting

If an error occurs starting a channel, don't "thaw" it.
We should assume the channel remains in a non-started state.

Update the comment in gsi_channel_stop(); calls to this function
are no longer retried.

Signed-off-by: Alex Elder <elder@linaro.org>
Acked-by: Willem de Bruijn <willemb@google.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
This commit is contained in:
Alex Elder 2021-02-01 11:28:44 -06:00 коммит произвёл Jakub Kicinski
Родитель 097b9146c0
Коммит 6b00a76a1d
1 изменённых файлов: 4 добавлений и 2 удалений

Просмотреть файл

@ -885,7 +885,9 @@ int gsi_channel_start(struct gsi *gsi, u32 channel_id)
mutex_unlock(&gsi->mutex);
gsi_channel_thaw(channel);
/* Thaw the channel if successful */
if (!ret)
gsi_channel_thaw(channel);
return ret;
}
@ -910,7 +912,7 @@ int gsi_channel_stop(struct gsi *gsi, u32 channel_id)
mutex_unlock(&gsi->mutex);
/* Thaw the channel if we need to retry (or on error) */
/* Re-thaw the channel if an error occurred while stopping */
if (ret)
gsi_channel_thaw(channel);