KVM: MMU: remove redundant check in mmu_set_spte
The following code flow is unnecessary: if (largepage) was_rmapped = is_large_pte(*shadow_pte); else was_rmapped = 1; The is_large_pte() function will always evaluate to one here because the (largepage && !is_large_pte) case is already handled in the first if-clause. So we can remove this check and set was_rmapped to one always here. Signed-off-by: Joerg Roedel <joerg.roedel@amd.com> Acked-by: Marcelo Tosatti <mtosatti@redhat.com> Signed-off-by: Avi Kivity <avi@redhat.com>
This commit is contained in:
Родитель
fc5659c8c6
Коммит
6bed6b9e84
|
@ -1791,12 +1791,8 @@ static void mmu_set_spte(struct kvm_vcpu *vcpu, u64 *shadow_pte,
|
|||
pgprintk("hfn old %lx new %lx\n",
|
||||
spte_to_pfn(*shadow_pte), pfn);
|
||||
rmap_remove(vcpu->kvm, shadow_pte);
|
||||
} else {
|
||||
if (largepage)
|
||||
was_rmapped = is_large_pte(*shadow_pte);
|
||||
else
|
||||
was_rmapped = 1;
|
||||
}
|
||||
} else
|
||||
was_rmapped = 1;
|
||||
}
|
||||
if (set_spte(vcpu, shadow_pte, pte_access, user_fault, write_fault,
|
||||
dirty, largepage, global, gfn, pfn, speculative, true)) {
|
||||
|
|
Загрузка…
Ссылка в новой задаче