nfsd: remove unneeded spinlock in nfsd_cache_update
The locking rules for cache entries say that locking the cache_lock isn't needed if you're just touching the current entry. Earlier in this function we set rp->c_state to RC_UNUSED without any locking, so I believe it's ok to do the same here. Signed-off-by: Jeff Layton <jlayton@redhat.com> Signed-off-by: J. Bruce Fields <bfields@redhat.com>
This commit is contained in:
Родитель
7b9e8522a6
Коммит
6dc8889589
|
@ -286,9 +286,7 @@ nfsd_cache_update(struct svc_rqst *rqstp, int cachetype, __be32 *statp)
|
|||
cachv = &rp->c_replvec;
|
||||
cachv->iov_base = kmalloc(len << 2, GFP_KERNEL);
|
||||
if (!cachv->iov_base) {
|
||||
spin_lock(&cache_lock);
|
||||
rp->c_state = RC_UNUSED;
|
||||
spin_unlock(&cache_lock);
|
||||
return;
|
||||
}
|
||||
cachv->iov_len = len << 2;
|
||||
|
|
Загрузка…
Ссылка в новой задаче