staging: wilc1000: fix incorrect copy of pmkid data
The pmkid data is meant be be copied to the previous item in the pmkidlist, however the code is just copying the data to itself because the src index into pmkidlist is the same as the dst index into pmkidlist. Fix this with i + 1 instead of i. Detected by CoverityScan,CID#13339465 ("Overlapping buffer in memory copy") Signed-off-by: Colin Ian King <colin.king@canonical.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Родитель
fe3184556e
Коммит
6e9f6b54c5
|
@ -1346,7 +1346,7 @@ static int del_pmksa(struct wiphy *wiphy, struct net_device *netdev,
|
|||
priv->pmkid_list.pmkidlist[i + 1].bssid,
|
||||
ETH_ALEN);
|
||||
memcpy(priv->pmkid_list.pmkidlist[i].pmkid,
|
||||
priv->pmkid_list.pmkidlist[i].pmkid,
|
||||
priv->pmkid_list.pmkidlist[i + 1].pmkid,
|
||||
PMKID_LEN);
|
||||
}
|
||||
priv->pmkid_list.numpmkid--;
|
||||
|
|
Загрузка…
Ссылка в новой задаче