clk: fixed-mmio: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Link: https://lore.kernel.org/r/20230312161512.2715500-10-u.kleine-koenig@pengutronix.de Signed-off-by: Stephen Boyd <sboyd@kernel.org>
This commit is contained in:
Родитель
27237f4b37
Коммит
6f149b6589
|
@ -71,14 +71,12 @@ static int of_fixed_mmio_clk_probe(struct platform_device *pdev)
|
|||
return 0;
|
||||
}
|
||||
|
||||
static int of_fixed_mmio_clk_remove(struct platform_device *pdev)
|
||||
static void of_fixed_mmio_clk_remove(struct platform_device *pdev)
|
||||
{
|
||||
struct clk_hw *clk = platform_get_drvdata(pdev);
|
||||
|
||||
of_clk_del_provider(pdev->dev.of_node);
|
||||
clk_hw_unregister_fixed_rate(clk);
|
||||
|
||||
return 0;
|
||||
}
|
||||
|
||||
static const struct of_device_id of_fixed_mmio_clk_ids[] = {
|
||||
|
@ -93,7 +91,7 @@ static struct platform_driver of_fixed_mmio_clk_driver = {
|
|||
.of_match_table = of_fixed_mmio_clk_ids,
|
||||
},
|
||||
.probe = of_fixed_mmio_clk_probe,
|
||||
.remove = of_fixed_mmio_clk_remove,
|
||||
.remove_new = of_fixed_mmio_clk_remove,
|
||||
};
|
||||
module_platform_driver(of_fixed_mmio_clk_driver);
|
||||
|
||||
|
|
Загрузка…
Ссылка в новой задаче