media: sti: Fix reference count leaks
pm_runtime_get_sync() increments the runtime PM usage counter even when it returns an error code, causing incorrect ref count if pm_runtime_put_noidle() is not called in error handling paths. Thus call pm_runtime_put_noidle() if pm_runtime_get_sync() fails. Signed-off-by: Qiushi Wu <wu000273@umn.edu> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
This commit is contained in:
Родитель
7ef64ceea0
Коммит
6f4432bae9
|
@ -272,6 +272,7 @@ static unsigned long int hva_hw_get_ip_version(struct hva_dev *hva)
|
|||
|
||||
if (pm_runtime_get_sync(dev) < 0) {
|
||||
dev_err(dev, "%s failed to get pm_runtime\n", HVA_PREFIX);
|
||||
pm_runtime_put_noidle(dev);
|
||||
mutex_unlock(&hva->protect_mutex);
|
||||
return -EFAULT;
|
||||
}
|
||||
|
@ -553,6 +554,7 @@ void hva_hw_dump_regs(struct hva_dev *hva, struct seq_file *s)
|
|||
|
||||
if (pm_runtime_get_sync(dev) < 0) {
|
||||
seq_puts(s, "Cannot wake up IP\n");
|
||||
pm_runtime_put_noidle(dev);
|
||||
mutex_unlock(&hva->protect_mutex);
|
||||
return;
|
||||
}
|
||||
|
|
Загрузка…
Ссылка в новой задаче