drm/omap: drop DRM_AUTH from DRM_RENDER_ALLOW ioctls
The authentication can be circumvented, by design, by using the render node. From the driver POV there is no distinction between primary and render nodes, thus we can drop the token. Note: the outstanding DRM_AUTH instance is: - (badly coped) legacy DRI1 ioctl, which is a noop Cc: Tomi Valkeinen <tomi.valkeinen@ti.com> Cc: David Airlie <airlied@linux.ie> Cc: Daniel Vetter <daniel@ffwll.ch> Signed-off-by: Emil Velikov <emil.velikov@collabora.com> Acked-by: Tomi Valkeinen <tomi.valkeinen@ti.com> Link: https://patchwork.freedesktop.org/patch/msgid/20190527081741.14235-9-emil.l.velikov@gmail.com
This commit is contained in:
Родитель
a305f6c5c8
Коммит
7042a33deb
|
@ -477,19 +477,19 @@ static int ioctl_gem_info(struct drm_device *dev, void *data,
|
||||||
|
|
||||||
static const struct drm_ioctl_desc ioctls[DRM_COMMAND_END - DRM_COMMAND_BASE] = {
|
static const struct drm_ioctl_desc ioctls[DRM_COMMAND_END - DRM_COMMAND_BASE] = {
|
||||||
DRM_IOCTL_DEF_DRV(OMAP_GET_PARAM, ioctl_get_param,
|
DRM_IOCTL_DEF_DRV(OMAP_GET_PARAM, ioctl_get_param,
|
||||||
DRM_AUTH | DRM_RENDER_ALLOW),
|
DRM_RENDER_ALLOW),
|
||||||
DRM_IOCTL_DEF_DRV(OMAP_SET_PARAM, drm_invalid_op,
|
DRM_IOCTL_DEF_DRV(OMAP_SET_PARAM, drm_invalid_op,
|
||||||
DRM_AUTH | DRM_MASTER | DRM_ROOT_ONLY),
|
DRM_AUTH | DRM_MASTER | DRM_ROOT_ONLY),
|
||||||
DRM_IOCTL_DEF_DRV(OMAP_GEM_NEW, ioctl_gem_new,
|
DRM_IOCTL_DEF_DRV(OMAP_GEM_NEW, ioctl_gem_new,
|
||||||
DRM_AUTH | DRM_RENDER_ALLOW),
|
DRM_RENDER_ALLOW),
|
||||||
/* Deprecated, to be removed. */
|
/* Deprecated, to be removed. */
|
||||||
DRM_IOCTL_DEF_DRV(OMAP_GEM_CPU_PREP, drm_noop,
|
DRM_IOCTL_DEF_DRV(OMAP_GEM_CPU_PREP, drm_noop,
|
||||||
DRM_AUTH | DRM_RENDER_ALLOW),
|
DRM_RENDER_ALLOW),
|
||||||
/* Deprecated, to be removed. */
|
/* Deprecated, to be removed. */
|
||||||
DRM_IOCTL_DEF_DRV(OMAP_GEM_CPU_FINI, drm_noop,
|
DRM_IOCTL_DEF_DRV(OMAP_GEM_CPU_FINI, drm_noop,
|
||||||
DRM_AUTH | DRM_RENDER_ALLOW),
|
DRM_RENDER_ALLOW),
|
||||||
DRM_IOCTL_DEF_DRV(OMAP_GEM_INFO, ioctl_gem_info,
|
DRM_IOCTL_DEF_DRV(OMAP_GEM_INFO, ioctl_gem_info,
|
||||||
DRM_AUTH | DRM_RENDER_ALLOW),
|
DRM_RENDER_ALLOW),
|
||||||
};
|
};
|
||||||
|
|
||||||
/*
|
/*
|
||||||
|
|
Загрузка…
Ссылка в новой задаче