zsmalloc: change return value unit of zs_get_total_size_bytes
zs_get_total_size_bytes returns a amount of memory zsmalloc consumed with *byte unit* but zsmalloc operates *page unit* rather than byte unit so let's change the API so benefit we could get is that reduce unnecessary overhead (ie, change page unit with byte unit) in zsmalloc. Since return type is pages, "zs_get_total_pages" is better than "zs_get_total_size_bytes". Signed-off-by: Minchan Kim <minchan@kernel.org> Reviewed-by: Dan Streetman <ddstreet@ieee.org> Cc: Sergey Senozhatsky <sergey.senozhatsky@gmail.com> Cc: Jerome Marchand <jmarchan@redhat.com> Cc: <juno.choi@lge.com> Cc: <seungho1.park@lge.com> Cc: Luigi Semenzato <semenzato@google.com> Cc: Nitin Gupta <ngupta@vflare.org> Cc: Seth Jennings <sjennings@variantweb.net> Cc: David Horner <ds2horner@gmail.com> Cc: Joonsoo Kim <iamjoonsoo.kim@lge.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Родитель
13de8933c9
Коммит
722cdc1723
|
@ -103,10 +103,10 @@ static ssize_t mem_used_total_show(struct device *dev,
|
||||||
|
|
||||||
down_read(&zram->init_lock);
|
down_read(&zram->init_lock);
|
||||||
if (init_done(zram))
|
if (init_done(zram))
|
||||||
val = zs_get_total_size_bytes(meta->mem_pool);
|
val = zs_get_total_pages(meta->mem_pool);
|
||||||
up_read(&zram->init_lock);
|
up_read(&zram->init_lock);
|
||||||
|
|
||||||
return scnprintf(buf, PAGE_SIZE, "%llu\n", val);
|
return scnprintf(buf, PAGE_SIZE, "%llu\n", val << PAGE_SHIFT);
|
||||||
}
|
}
|
||||||
|
|
||||||
static ssize_t max_comp_streams_show(struct device *dev,
|
static ssize_t max_comp_streams_show(struct device *dev,
|
||||||
|
|
|
@ -46,6 +46,6 @@ void *zs_map_object(struct zs_pool *pool, unsigned long handle,
|
||||||
enum zs_mapmode mm);
|
enum zs_mapmode mm);
|
||||||
void zs_unmap_object(struct zs_pool *pool, unsigned long handle);
|
void zs_unmap_object(struct zs_pool *pool, unsigned long handle);
|
||||||
|
|
||||||
u64 zs_get_total_size_bytes(struct zs_pool *pool);
|
unsigned long zs_get_total_pages(struct zs_pool *pool);
|
||||||
|
|
||||||
#endif
|
#endif
|
||||||
|
|
|
@ -297,7 +297,7 @@ static void zs_zpool_unmap(void *pool, unsigned long handle)
|
||||||
|
|
||||||
static u64 zs_zpool_total_size(void *pool)
|
static u64 zs_zpool_total_size(void *pool)
|
||||||
{
|
{
|
||||||
return zs_get_total_size_bytes(pool);
|
return zs_get_total_pages(pool) << PAGE_SHIFT;
|
||||||
}
|
}
|
||||||
|
|
||||||
static struct zpool_driver zs_zpool_driver = {
|
static struct zpool_driver zs_zpool_driver = {
|
||||||
|
@ -1181,12 +1181,11 @@ void zs_unmap_object(struct zs_pool *pool, unsigned long handle)
|
||||||
}
|
}
|
||||||
EXPORT_SYMBOL_GPL(zs_unmap_object);
|
EXPORT_SYMBOL_GPL(zs_unmap_object);
|
||||||
|
|
||||||
u64 zs_get_total_size_bytes(struct zs_pool *pool)
|
unsigned long zs_get_total_pages(struct zs_pool *pool)
|
||||||
{
|
{
|
||||||
u64 npages = atomic_long_read(&pool->pages_allocated);
|
return atomic_long_read(&pool->pages_allocated);
|
||||||
return npages << PAGE_SHIFT;
|
|
||||||
}
|
}
|
||||||
EXPORT_SYMBOL_GPL(zs_get_total_size_bytes);
|
EXPORT_SYMBOL_GPL(zs_get_total_pages);
|
||||||
|
|
||||||
module_init(zs_init);
|
module_init(zs_init);
|
||||||
module_exit(zs_exit);
|
module_exit(zs_exit);
|
||||||
|
|
Загрузка…
Ссылка в новой задаче