drm/virtio: Fix error code in virtio_gpu_object_shmem_init()
In virtio_gpu_object_shmem_init() we are passing NULL to PTR_ERR, which
is returning 0/success.
Fix this by storing error value in 'ret' variable before assigning
shmem->pages to NULL.
Found using static analysis with Smatch.
Fixes: 64b88afbd9
("drm/virtio: Correct drm_gem_shmem_get_sg_table() error handling")
Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Reviewed-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Родитель
8e62139840
Коммит
72bf6d493c
|
@ -169,8 +169,9 @@ static int virtio_gpu_object_shmem_init(struct virtio_gpu_device *vgdev,
|
|||
shmem->pages = drm_gem_shmem_get_sg_table(&bo->base);
|
||||
if (IS_ERR(shmem->pages)) {
|
||||
drm_gem_shmem_unpin(&bo->base);
|
||||
ret = PTR_ERR(shmem->pages);
|
||||
shmem->pages = NULL;
|
||||
return PTR_ERR(shmem->pages);
|
||||
return ret;
|
||||
}
|
||||
|
||||
if (use_dma_api) {
|
||||
|
|
Загрузка…
Ссылка в новой задаче