pinctrl:sunplus: Add check for kmalloc
Fix Smatch static checker warning:
potential null dereference 'configs'. (kmalloc returns null)
Changes in v2:
1. Add free allocated memory before returned -ENOMEM.
2. Add call of_node_put() before returned -ENOMEM.
Fixes: aa74c44be1
("pinctrl: Add driver for Sunplus SP7021")
Signed-off-by: Wells Lu <wellslutw@gmail.com>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Link: https://lore.kernel.org/r/1685277277-12209-1-git-send-email-wellslutw@gmail.com
[Rebased on the patch from Lu Hongfei]
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
This commit is contained in:
Родитель
b2132afec0
Коммит
73f8ce7f96
|
@ -971,8 +971,7 @@ static int sppctl_dt_node_to_map(struct pinctrl_dev *pctldev, struct device_node
|
|||
|
||||
sppctl_map_err:
|
||||
for (i = 0; i < (*num_maps); i++)
|
||||
if (((*map)[i].type == PIN_MAP_TYPE_CONFIGS_PIN) &&
|
||||
(*map)[i].data.configs.configs)
|
||||
if ((*map)[i].type == PIN_MAP_TYPE_CONFIGS_PIN)
|
||||
kfree((*map)[i].data.configs.configs);
|
||||
kfree(*map);
|
||||
of_node_put(parent);
|
||||
|
|
Загрузка…
Ссылка в новой задаче