Input: mousedev - fix memory leak
Apparently, "while true; do cat </dev/null >/dev/input/mice; done" causes an OOM in a short amount of time. Funny that nobody noticed, it actually is very easy to trigger just by switching between VT1 and VT7... Signed-off-by: Pete Zaitcev <zaitcev@redhat.com> Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
This commit is contained in:
Родитель
5ae08f80ec
Коммит
74570d413c
|
@ -356,7 +356,7 @@ static void mousedev_free(struct mousedev *mousedev)
|
|||
kfree(mousedev);
|
||||
}
|
||||
|
||||
static int mixdev_release(void)
|
||||
static void mixdev_release(void)
|
||||
{
|
||||
struct input_handle *handle;
|
||||
|
||||
|
@ -370,8 +370,6 @@ static int mixdev_release(void)
|
|||
mousedev_free(mousedev);
|
||||
}
|
||||
}
|
||||
|
||||
return 0;
|
||||
}
|
||||
|
||||
static int mousedev_release(struct inode * inode, struct file * file)
|
||||
|
@ -384,9 +382,8 @@ static int mousedev_release(struct inode * inode, struct file * file)
|
|||
|
||||
if (!--list->mousedev->open) {
|
||||
if (list->mousedev->minor == MOUSEDEV_MIX)
|
||||
return mixdev_release();
|
||||
|
||||
if (!mousedev_mix.open) {
|
||||
mixdev_release();
|
||||
else if (!mousedev_mix.open) {
|
||||
if (list->mousedev->exist)
|
||||
input_close_device(&list->mousedev->handle);
|
||||
else
|
||||
|
|
Загрузка…
Ссылка в новой задаче