ASoC: rt5682s: Fix crash due to out of scope stack vars
Move the declaration of temporary arrays to somewhere that won't go out
of scope before the devm_clk_hw_register() call, lest we be at the whim
of the compiler for whether those stack variables get overwritten.
Fixes a crash seen with gcc version 11.2.1 20210728 (Red Hat 11.2.1-1)
Fixes: bdd229ab26
("ASoC: rt5682s: Add driver for ALC5682I-VS codec")
Signed-off-by: Rob Clark <robdclark@chromium.org>
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
Link: https://lore.kernel.org/r/20211118010453.843286-2-robdclark@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
This commit is contained in:
Родитель
4999d703c0
Коммит
750dc2f622
|
@ -2693,6 +2693,8 @@ static int rt5682s_register_dai_clks(struct snd_soc_component *component)
|
|||
|
||||
for (i = 0; i < RT5682S_DAI_NUM_CLKS; ++i) {
|
||||
struct clk_init_data init = { };
|
||||
struct clk_parent_data parent_data;
|
||||
const struct clk_hw *parent;
|
||||
|
||||
dai_clk_hw = &rt5682s->dai_clks_hw[i];
|
||||
|
||||
|
@ -2700,17 +2702,17 @@ static int rt5682s_register_dai_clks(struct snd_soc_component *component)
|
|||
case RT5682S_DAI_WCLK_IDX:
|
||||
/* Make MCLK the parent of WCLK */
|
||||
if (rt5682s->mclk) {
|
||||
init.parent_data = &(struct clk_parent_data){
|
||||
parent_data = (struct clk_parent_data){
|
||||
.fw_name = "mclk",
|
||||
};
|
||||
init.parent_data = &parent_data;
|
||||
init.num_parents = 1;
|
||||
}
|
||||
break;
|
||||
case RT5682S_DAI_BCLK_IDX:
|
||||
/* Make WCLK the parent of BCLK */
|
||||
init.parent_hws = &(const struct clk_hw *){
|
||||
&rt5682s->dai_clks_hw[RT5682S_DAI_WCLK_IDX]
|
||||
};
|
||||
parent = &rt5682s->dai_clks_hw[RT5682S_DAI_WCLK_IDX];
|
||||
init.parent_hws = &parent;
|
||||
init.num_parents = 1;
|
||||
break;
|
||||
default:
|
||||
|
|
Загрузка…
Ссылка в новой задаче